LGTM with nits.
https://codereview.chromium.org/133773002/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/133773002/diff/1/src/hydrogen.cc#newcode7572
src/hydrogen.cc:7572: Drop(1); // Pop the function
nit: trailing full stop please.
https://codereview.chromium.org/133773002/diff/1/test/mjsunit/arguments-apply-deopt.js
File test/mjsunit/arguments-apply-deopt.js (right):
https://codereview.chromium.org/133773002/diff/1/test/mjsunit/arguments-apply-deopt.js#newcode32
test/mjsunit/arguments-apply-deopt.js:32: return function XXXXX() {
nit: indentation is inconsistent here and again several times below.
https://codereview.chromium.org/133773002/diff/1/test/mjsunit/arguments-apply-deopt.js#newcode49
test/mjsunit/arguments-apply-deopt.js:49: for (var i = 0; i < 200; i++)
{
use a smaller loop count here (say, 3), and %OptimizeFunctionOnNextCall
as necessary.
https://codereview.chromium.org/133773002/diff/1/test/mjsunit/arguments-apply-deopt.js#newcode56
test/mjsunit/arguments-apply-deopt.js:56: (function
ApplyArgumetsDeoptInReceiverExplicit() {
nit: s/Argumets/Arguments/
https://codereview.chromium.org/133773002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
