Reviewers: Hannes Payer,
Message:
PTAL, thx!
Description:
Turn on allocation site pretenuring.
BUG=
Please review this at https://codereview.chromium.org/133643005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -3 lines):
M src/flag-definitions.h
M test/cctest/test-heap.cc
Index: src/flag-definitions.h
diff --git a/src/flag-definitions.h b/src/flag-definitions.h
index
93adb620da0d51668cde4dc84a9fb713fbf704d4..bbad22738a45b0a1302d2959f7463a45b1f0e75f
100644
--- a/src/flag-definitions.h
+++ b/src/flag-definitions.h
@@ -220,7 +220,7 @@ DEFINE_bool(pretenuring, true, "allocate objects in old
space")
// TODO(hpayer): We will remove this flag as soon as we have pretenuring
// support for specific allocation sites.
DEFINE_bool(pretenuring_call_new, false, "pretenure call new")
-DEFINE_bool(allocation_site_pretenuring, false,
+DEFINE_bool(allocation_site_pretenuring, true,
"pretenure with allocation sites")
DEFINE_bool(trace_pretenuring, false,
"trace pretenuring decisions of HAllocate instructions")
Index: test/cctest/test-heap.cc
diff --git a/test/cctest/test-heap.cc b/test/cctest/test-heap.cc
index
d5fae581deb8fb96b8fda9270cfd5341ef76de80..dbdb0ccfa250555823381a38350d27f4be5b8a4a
100644
--- a/test/cctest/test-heap.cc
+++ b/test/cctest/test-heap.cc
@@ -2240,7 +2240,7 @@ TEST(OptimizedPretenuringAllocationFoldingBlocks) {
CcTest::heap()->SetNewSpaceHighPromotionModeActive(true);
v8::Local<v8::Value> res = CompileRun(
- "var number_elements = 3000;"
+ "var number_elements = 10000;"
"var elements = new Array(number_elements);"
"function DataObject() {"
" this.a = [{}];"
@@ -2349,7 +2349,7 @@ TEST(OptimizedPretenuringDoubleArrayProperties) {
"var elements = new Array(number_elements);"
"function f() {"
" for (var i = 0; i < number_elements; i++) {"
- " elements[i] = {a: 1.1, b: 2.2};"
+ " elements[i] = {a: 1.1, b: 2.2, c: 3.3};"
" }"
" return elements[i - 1];"
"};"
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
