Reviewers: Jakob,
Message:
PTAL
Description:
Revert "Add debug output to presubmit script for investigating tree check
behavior." and "Add more temporary debugging output to PRESUBMIT.py".
This reverts commits r18538 and r18528, since the investigated problem was
found.
BUG=
Please review this at https://codereview.chromium.org/133993002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -8 lines):
M PRESUBMIT.py
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index
71907be309d23404e3a5b8dbda6bd682cd2febc5..fe15157dde7f7e237bb85a77725f6e08b89c3714
100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -61,15 +61,11 @@ def _CommonChecks(input_api, output_api):
def _SkipTreeCheck(input_api, output_api):
"""Check the env var whether we want to skip tree check.
Only skip if src/version.cc has been updated."""
- print "skip tree check?", input_api.environ.get('PRESUBMIT_TREE_CHECK')
src_version = 'src/version.cc'
- def FilterFile(file):
- print "Changed file:", file.LocalPath()
- return file.LocalPath() == src_version
- if not input_api.AffectedSourceFiles(FilterFile):
+ FilterFile = lambda file: file.LocalPath() == src_version
+ if not input_api.AffectedSourceFiles(
+ lambda file: file.LocalPath() == src_version):
return False
- if input_api.environ.get('PRESUBMIT_TREE_CHECK') == 'skip':
- print "Skip tree check requested via environment variable."
return input_api.environ.get('PRESUBMIT_TREE_CHECK') == 'skip'
@@ -98,7 +94,6 @@ def CheckChangeOnCommit(input_api, output_api):
results.extend(input_api.canned_checks.CheckChangeHasDescription(
input_api, output_api))
if not _SkipTreeCheck(input_api, output_api):
- print "Checking if tree is open."
results.extend(input_api.canned_checks.CheckTreeIsOpen(
input_api, output_api,
json_url='http://v8-status.appspot.com/current?format=json'))
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
