Revision: 18544
Author: [email protected]
Date: Fri Jan 10 15:17:49 2014 UTC
Log: Revert "Add debug output to presubmit script for investigating
tree check behavior." and "Add more temporary debugging output to
PRESUBMIT.py".
This reverts commits r18538 and r18528, since the investigated problem was
found.
BUG=
[email protected]
Review URL: https://codereview.chromium.org/133993002
http://code.google.com/p/v8/source/detail?r=18544
Modified:
/branches/bleeding_edge/PRESUBMIT.py
=======================================
--- /branches/bleeding_edge/PRESUBMIT.py Fri Jan 10 13:48:43 2014 UTC
+++ /branches/bleeding_edge/PRESUBMIT.py Fri Jan 10 15:17:49 2014 UTC
@@ -61,15 +61,11 @@
def _SkipTreeCheck(input_api, output_api):
"""Check the env var whether we want to skip tree check.
Only skip if src/version.cc has been updated."""
- print "skip tree check?", input_api.environ.get('PRESUBMIT_TREE_CHECK')
src_version = 'src/version.cc'
- def FilterFile(file):
- print "Changed file:", file.LocalPath()
- return file.LocalPath() == src_version
- if not input_api.AffectedSourceFiles(FilterFile):
+ FilterFile = lambda file: file.LocalPath() == src_version
+ if not input_api.AffectedSourceFiles(
+ lambda file: file.LocalPath() == src_version):
return False
- if input_api.environ.get('PRESUBMIT_TREE_CHECK') == 'skip':
- print "Skip tree check requested via environment variable."
return input_api.environ.get('PRESUBMIT_TREE_CHECK') == 'skip'
@@ -98,7 +94,6 @@
results.extend(input_api.canned_checks.CheckChangeHasDescription(
input_api, output_api))
if not _SkipTreeCheck(input_api, output_api):
- print "Checking if tree is open."
results.extend(input_api.canned_checks.CheckTreeIsOpen(
input_api, output_api,
json_url='http://v8-status.appspot.com/current?format=json'))
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
