https://codereview.chromium.org/121173009/diff/300001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/121173009/diff/300001/include/v8.h#newcode1652
include/v8.h:1652: // @TODO Rename to REPLACE_INVALID_UTF8?
sure
https://codereview.chromium.org/121173009/diff/300001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/121173009/diff/300001/src/api.cc#newcode4709
src/api.cc:4709: capacity /
static_cast<int>(unibrow::Utf8::kMax16BitCodeUnitSize)
this formatting is funny
either use clang format or move the constant above the if statement to
make it shorter
https://codereview.chromium.org/121173009/diff/300001/src/unicode-inl.h
File src/unicode-inl.h (right):
https://codereview.chromium.org/121173009/diff/300001/src/unicode-inl.h#newcode116
src/unicode-inl.h:116: bool allow_invalid = true) {
default should be in declaration
https://codereview.chromium.org/121173009/diff/300001/src/unicode.h
File src/unicode.h (right):
https://codereview.chromium.org/121173009/diff/300001/src/unicode.h#newcode155
src/unicode.h:155: bool allow_invalid);
needs default value
https://codereview.chromium.org/121173009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
