LGTM, test nits.
https://codereview.chromium.org/117483002/diff/150001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/117483002/diff/150001/test/cctest/test-heap.cc#newcode3705
test/cctest/test-heap.cc:3705: heap->CollectAllGarbage(false);
Is calling 3 times the GC not good enough? Moreover, I would call
CollectAllGarbage with Heap::kAbortIncrementalMarkingMask to make it
more robust on the stress GC builders.
https://codereview.chromium.org/117483002/diff/150001/test/cctest/test-heap.cc#newcode3746
test/cctest/test-heap.cc:3746: heap->CollectAllGarbage(false);
Same as above.
https://codereview.chromium.org/117483002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
