Reviewers: marja,
Message:
Committed patchset #1 manually as r18610.
Description:
Experimental parser: elide cursor reads in some cases
[email protected]
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=18610
Please review this at https://codereview.chromium.org/139303002/
SVN Base: https://v8.googlecode.com/svn/branches/experimental/parser
Affected files (+7, -1 lines):
M tools/lexer_generator/code_generator.jinja
M tools/lexer_generator/code_generator.py
Index: tools/lexer_generator/code_generator.jinja
diff --git a/tools/lexer_generator/code_generator.jinja
b/tools/lexer_generator/code_generator.jinja
index
9b99de4b3276b2a9fde092b714456fe7fe3c9938..67ccb56a3d60b5670a40d3597e98589d77d0e041
100644
--- a/tools/lexer_generator/code_generator.jinja
+++ b/tools/lexer_generator/code_generator.jinja
@@ -205,7 +205,9 @@
{{ write_label('state_entry', node_number_chain) }}
- READ_CURSOR();
+ {% if not state['can_elide_read'] -%}
+ READ_CURSOR();
+ {%- endif -%}
{% if debug_print %}
fprintf(stderr,
Index: tools/lexer_generator/code_generator.py
diff --git a/tools/lexer_generator/code_generator.py
b/tools/lexer_generator/code_generator.py
index
5f02ebb33899df636d9a1a83e6eb9831ad836036..d503a1dc67373a96469749366abf6a7406ae3616
100644
--- a/tools/lexer_generator/code_generator.py
+++ b/tools/lexer_generator/code_generator.py
@@ -99,6 +99,7 @@ class CodeGenerator:
'node_number' : None,
'original_node_number' : state.node_number(),
'transitions' : transitions,
+ 'can_elide_read' : len(transitions) == 0,
'switch_transitions' : [],
'deferred_transitions' : [],
'long_char_transitions' : [],
@@ -286,6 +287,9 @@ class CodeGenerator:
state['match_action'] = (state['match_action'][0], value)
if state['match_action'][0] != 'goto_start':
states[value[-1]]['entry_points']['after_entry_code'] = True
+ state['can_elide_read'] = False
+ else:
+ states[value[-1]]['can_elide_read'] = False
@staticmethod
def __mark_entry_points(dfa_states):
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
