lgtm, but please fix the test
https://codereview.chromium.org/139263008/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/139263008/diff/1/test/cctest/test-api.cc#newcode21638
test/cctest/test-api.cc:21638: TEST(Regress239669) {
this test doesn't test the stub you changed
please change it to the following
LocalContext context;
v8::Isolate* isolate = context->GetIsolate();
v8::HandleScope scope(isolate);
Local<ObjectTemplate> templ = ObjectTemplate::New(isolate);
templ->SetAccessor(v8_str("x"), 0,
SetterWhichExpectsThisAndHolderToDiffer);
context->Global()->Set(v8_str("P"), templ->NewInstance());
CompileRun(
"function C1() {"
" this.x = 23;"
"};"
"C1.prototype = P;"
"for (var i = 0; i < 4; i++ ) {"
" new C1();"
"}");
https://codereview.chromium.org/139263008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
