Reviewers: ,

Message:
Committed patchset #1 manually as r18644 (presubmit successful).

Description:
Experimental parser: fix an assert to be more meaningful.

BUG=
[email protected]

Committed: https://code.google.com/p/v8/source/detail?r=18644

Please review this at https://codereview.chromium.org/139303008/

SVN Base: https://v8.googlecode.com/svn/branches/experimental/parser

Affected files (+3, -1 lines):
  M tools/lexer_generator/dfa.py


Index: tools/lexer_generator/dfa.py
diff --git a/tools/lexer_generator/dfa.py b/tools/lexer_generator/dfa.py
index f135b8e1e9d133298be386664c186365bb89a585..a8f29cdbd6a2389fe79e49e68dadd8330beae9b0 100644
--- a/tools/lexer_generator/dfa.py
+++ b/tools/lexer_generator/dfa.py
@@ -189,7 +189,9 @@ class DfaMinimizer:
       all_keys.append(state.key_iter())
       if action:
         if state not in terminal_set:
-          assert action.entry_action()
+ # Match actions are valid only if we have matched the whole token, not
+          # just some sub-part of it.
+          assert not action.match_action()
           key = ("nonterminal action", action)
         else:
           key = ("terminal action", action)


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to