https://codereview.chromium.org/140913009/diff/50001/src/lexer/experimental-scanner.cc
File src/lexer/experimental-scanner.cc (right):
https://codereview.chromium.org/140913009/diff/50001/src/lexer/experimental-scanner.cc#newcode68
src/lexer/experimental-scanner.cc:68: if (*cursor >=
unibrow::Latin1::kMaxChar) return true;
Wut? true and false reversed maybe?
https://codereview.chromium.org/140913009/diff/50001/src/lexer/experimental-scanner.cc#newcode206
src/lexer/experimental-scanner.cc:206: int from = literal->offset;
Can you add a comment here (or to a more suitable file) describing why
and how. I suppose NewRawOneByte can cause GC, and this works because we
only get the offset before the possible GC, and then after GC read the
actual data from the string....
https://codereview.chromium.org/140913009/diff/50001/src/lexer/experimental-scanner.h
File src/lexer/experimental-scanner.h (right):
https://codereview.chromium.org/140913009/diff/50001/src/lexer/experimental-scanner.h#newcode261
src/lexer/experimental-scanner.h:261: if (!next_literal_->is_in_buffer)
next_literal_->beg_pos = -1;
Shouldn't we reset is_in_buffer here too? Why not?
https://codereview.chromium.org/140913009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
