Revision: 18686
Author: [email protected]
Date: Mon Jan 20 10:43:27 2014 UTC
Log: Experimental lexer: fix style issues.
[email protected]
Review URL: https://codereview.chromium.org/143223002
http://code.google.com/p/v8/source/detail?r=18686
Modified:
/branches/experimental/parser/src/char-predicates.h
/branches/experimental/parser/src/isolate.cc
/branches/experimental/parser/src/lexer/experimental-scanner.h
/branches/experimental/parser/src/lexer/lexer-shell.cc
/branches/experimental/parser/src/preparser.h
=======================================
--- /branches/experimental/parser/src/char-predicates.h Wed Nov 20 16:10:09
2013 UTC
+++ /branches/experimental/parser/src/char-predicates.h Mon Jan 20 10:43:27
2014 UTC
@@ -66,6 +66,7 @@
}
};
+
struct IdentifierPartNotLetter {
static inline bool Is(uc32 c) {
return unibrow::Number::Is(c)
=======================================
--- /branches/experimental/parser/src/isolate.cc Fri Jan 17 11:13:31 2014
UTC
+++ /branches/experimental/parser/src/isolate.cc Mon Jan 20 10:43:27 2014
UTC
@@ -1093,9 +1093,9 @@
void Isolate::UpdateScannersAfterGC() {
for (std::set<ScannerBase*>::const_iterator it = scanners_.begin();
- it != scanners_.end();
- ++it)
+ it != scanners_.end(); ++it) {
(*it)->UpdateBufferBasedOnHandle();
+ }
}
=======================================
--- /branches/experimental/parser/src/lexer/experimental-scanner.h Mon Jan
20 09:25:23 2014 UTC
+++ /branches/experimental/parser/src/lexer/experimental-scanner.h Mon Jan
20 10:43:27 2014 UTC
@@ -628,6 +628,7 @@
literal->AddChar(c);
return cursor;
}
+
template<typename Char>
ScannerBase::Location ExperimentalScanner<Char>::octal_position() const {
=======================================
--- /branches/experimental/parser/src/lexer/lexer-shell.cc Wed Jan 15
12:13:18 2014 UTC
+++ /branches/experimental/parser/src/lexer/lexer-shell.cc Mon Jan 20
10:43:27 2014 UTC
@@ -72,8 +72,7 @@
}
*end = &chars[size];
- if (!convert_to_utf16)
- return chars;
+ if (!convert_to_utf16) return chars;
// Length of new_chars is not strictly accurate, but should be enough.
uint16_t* new_chars = new uint16_t[size];
@@ -83,8 +82,9 @@
uc32 c;
// The 32-bit char type is probably only so that we can have -1 as a
return
// value. If the char is not -1, it should fit into 16 bits.
- while ((c = stream.Advance()) != -1)
+ while ((c = stream.Advance()) != -1) {
*cursor++ = c;
+ }
*end = reinterpret_cast<byte*>(cursor);
}
delete[] chars;
=======================================
--- /branches/experimental/parser/src/preparser.h Tue Dec 3 10:23:38 2013
UTC
+++ /branches/experimental/parser/src/preparser.h Mon Jan 20 10:43:27 2014
UTC
@@ -74,19 +74,22 @@
void set_allow_for_of(bool allow) { allow_for_of_ = allow; }
void set_allow_modules(bool allow) {
allow_harmony_modules_ = allow;
- if (scanner())
+ if (scanner()) {
scanner()->SetHarmonyModules(allow);
+ }
}
void set_allow_harmony_scoping(bool allow) {
allow_harmony_scoping_ = allow;
- if (scanner())
+ if (scanner()) {
scanner()->SetHarmonyScoping(allow);
+ }
}
void set_allow_harmony_numeric_literals(bool allow) {
allow_harmony_numeric_literals_ = allow;
- if (scanner())
+ if (scanner()) {
scanner()->SetHarmonyNumericLiterals(allow);
+ }
}
protected:
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
