Reviewers: ulan,

Message:
Committed patchset #1 manually as r18690 (presubmit successful).

Description:
Fix *.py and *.jinja in build rules. They don't really work.

Unfortunately, the suggested way to get this to work is to list the files
explicitly.

[email protected]
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=18690

Please review this at https://codereview.chromium.org/137713003/

SVN Base: https://v8.googlecode.com/svn/branches/experimental/parser

Affected files (+22, -9 lines):
  M tools/gyp/v8.gyp


Index: tools/gyp/v8.gyp
diff --git a/tools/gyp/v8.gyp b/tools/gyp/v8.gyp
index 59bbba85dd205343dd98c0a61ce77bd7f930043b..68879c42abdb334df7209f16c4a7b0e791977158 100644
--- a/tools/gyp/v8.gyp
+++ b/tools/gyp/v8.gyp
@@ -236,13 +236,30 @@
     {
       'target_name': 'generated-lexer',
       'type': 'none',
+      'variables': {
+        'lexer_generator_files': [
+          '../../src/lexer/lexer_py.re',
+          '../../tools/lexer_generator/code_generator.jinja',
+          '../../tools/lexer_generator/automaton.py',
+          '../../tools/lexer_generator/code_generator.py',
+          '../../tools/lexer_generator/dfa_optimizer.py',
+          '../../tools/lexer_generator/dfa.py',
+          '../../tools/lexer_generator/generator.py',
+          '../../tools/lexer_generator/__init__.py',
+          '../../tools/lexer_generator/nfa_builder.py',
+          '../../tools/lexer_generator/nfa.py',
+          '../../tools/lexer_generator/regex_lexer.py',
+          '../../tools/lexer_generator/regex_parser.py',
+          '../../tools/lexer_generator/rule_lexer.py',
+          '../../tools/lexer_generator/rule_parser.py',
+          '../../tools/lexer_generator/transition_keys.py',
+        ],
+      },
       'actions': [
         {
           'action_name': 'codegen_8',
           'inputs': [
-            '../../src/lexer/lexer_py.re',
-            '../../tools/lexer_generator/*.py',
-            '../../tools/lexer_generator/*.jinja',
+            '<@(lexer_generator_files)',
           ],
           'outputs': [
             '<(SHARED_INTERMEDIATE_DIR)/generated_lexer_latin1.cc',
@@ -258,9 +275,7 @@
         {
           'action_name': 'codegen_16',
           'inputs': [
-            '../../src/lexer/lexer_py.re',
-            '../../tools/lexer_generator/*.py',
-            '../../tools/lexer_generator/*.jinja',
+            '<@(lexer_generator_files)',
           ],
           'outputs': [
             '<(SHARED_INTERMEDIATE_DIR)/generated_lexer_utf16.cc',
@@ -276,9 +291,7 @@
         {
           'action_name': 'codegen_utf8',
           'inputs': [
-            '../../src/lexer/lexer_py.re',
-            '../../tools/lexer_generator/*.py',
-            '../../tools/lexer_generator/*.jinja',
+            '<@(lexer_generator_files)',
           ],
           'outputs': [
             '<(SHARED_INTERMEDIATE_DIR)/generated_lexer_utf8.cc',


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to