Hi Toon, looks great, I just have a couple comments.
thx,
--Michael
https://codereview.chromium.org/137783023/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/137783023/diff/1/src/hydrogen.cc#newcode7645
src/hydrogen.cc:7645: bounds_check, elements_kind, false);
Can we make the boolean parameter to AddElementAccess be a LOAD/STORE
enum? It's a bit jarring because I expect to see some indication in the
line that we are doing a load here and a store below.
https://codereview.chromium.org/137783023/diff/1/src/hydrogen.cc#newcode7652
src/hydrogen.cc:7652: elements_kind = FAST_HOLEY_ELEMENTS;
This line confuses me a bit. A) Why wouldn't the elements_kind just
change to be the holey version of whatever it was? B) Why would double
be excluded from this operation? And if A) proves to be good enough,
then you could eliminate the change to elements kind in the case that
it's already holey.
If you have to do this for a technical reason so that that store works
out correctly, add a comment to explain.
https://codereview.chromium.org/137783023/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
