Reviewers: Sven Panne,
Message:
Hey Sven,
Here's an easy starter for today. Fortunately the bug did not trigger any
bad
behavior except for some unnecessary checks that were emitted in Hydrogen.
PTAL
-- Benedikt
Description:
Fix invalid type assumption in GenerateNumberToString().
We don't have any type feedback in %_NumberToString(), so it's
a bug to assume Type::Number here.
Please review this at https://codereview.chromium.org/143893002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M src/hydrogen.cc
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index
63b6da7e8b29b792e9bb6403f365bb3bda325615..3fb867bde3d5ed6403c6ee474a2e5dca71469d1c
100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -10277,7 +10277,7 @@ void
HOptimizedGraphBuilder::GenerateNumberToString(CallRuntime* call) {
ASSERT_EQ(1, call->arguments()->length());
CHECK_ALIVE(VisitForValue(call->arguments()->at(0)));
HValue* number = Pop();
- HValue* result = BuildNumberToString(number, Type::Number(isolate()));
+ HValue* result = BuildNumberToString(number, Type::Any(isolate()));
return ast_context()->ReturnValue(result);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
