lgtm. I chatted with MStarzinger too about the %SetAllocationTimeout call.
This
helper doesn't actually get every allocation, only ones that go into the
runtime
for some reason. So...to be *really* exact, we'd want to make
SetAllocationTimeout take another parameter which will actually force the
next
real allocation to come into the runtime (where this check will force a GC).
MStarzinger suggested he could do that in a future CL, or I could help too.
This
could increase the effectiveness of your change here...
https://codereview.chromium.org/138503008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
