LGTM if comments are addressed.
For the record, this breaks nice abstractions in the StaticMarkingVisitor
and my
heart bleeds a little looking at this change.
https://codereview.chromium.org/144003007/diff/40001/src/objects-visiting-inl.h
File src/objects-visiting-inl.h (right):
https://codereview.chromium.org/144003007/diff/40001/src/objects-visiting-inl.h#newcode632
src/objects-visiting-inl.h:632:
nit: Please drop the empty newline. The comment above shouldn't be
separated from the block of code below.
https://codereview.chromium.org/144003007/diff/40001/src/objects-visiting-inl.h#newcode648
src/objects-visiting-inl.h:648: StaticVisitor::VisitPointers(heap,
Can we move the visiting of the header slots to before we record the
entry slots? Then the memory is accessed sequentially. Also it is easier
to read.
https://codereview.chromium.org/144003007/diff/40001/src/objects-visiting-inl.h#newcode655
src/objects-visiting-inl.h:655: StaticVisitor::VisitPointers(heap,
The call to VisitPointers here is obsolete.
https://codereview.chromium.org/144003007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
