Reviewers: rossberg, danno, Paul Lind, kisg, kilvadyb, dusmil,
Message:
PTAL.
Description:
MIPS: Zonify types in compiler frontend
Port r18719 (13303b7a)
Original commit message:
Clean up some zone/isolate handling in AST and its visitors on the way.
(Based on https://codereview.chromium.org/103743004/)
BUG=
Please review this at https://codereview.chromium.org/143873005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+8, -8 lines):
M src/mips/codegen-mips.h
M src/mips/stub-cache-mips.cc
Index: src/mips/codegen-mips.h
diff --git a/src/mips/codegen-mips.h b/src/mips/codegen-mips.h
index
822b94ad7998629412cbdffef081c2e4ab9e8938..278b20025631ad9a4296b04928b9da17735211bc
100644
--- a/src/mips/codegen-mips.h
+++ b/src/mips/codegen-mips.h
@@ -46,8 +46,8 @@ enum TypeofState { INSIDE_TYPEOF, NOT_INSIDE_TYPEOF };
class CodeGenerator: public AstVisitor {
public:
- explicit CodeGenerator(Isolate* isolate) {
- InitializeAstVisitor(isolate);
+ explicit CodeGenerator(Zone* zone) {
+ InitializeAstVisitor(zone);
}
static bool MakeCode(CompilationInfo* info);
Index: src/mips/stub-cache-mips.cc
diff --git a/src/mips/stub-cache-mips.cc b/src/mips/stub-cache-mips.cc
index
f9f6f89e561dc6355980c1c408bf9e279a628784..23ef6ece97ea53c6463a48e40c07286fb37b250e
100644
--- a/src/mips/stub-cache-mips.cc
+++ b/src/mips/stub-cache-mips.cc
@@ -1107,7 +1107,7 @@ void StubCompiler::GenerateTailCall(MacroAssembler*
masm, Handle<Code> code) {
#define __ ACCESS_MASM(masm())
-Register StubCompiler::CheckPrototypes(Handle<Type> type,
+Register StubCompiler::CheckPrototypes(Handle<HeapType> type,
Register object_reg,
Handle<JSObject> holder,
Register holder_reg,
@@ -1253,7 +1253,7 @@ void
StoreStubCompiler::HandlerFrontendFooter(Handle<Name> name, Label* miss) {
Register LoadStubCompiler::CallbackHandlerFrontend(
- Handle<Type> type,
+ Handle<HeapType> type,
Register object_reg,
Handle<JSObject> holder,
Handle<Name> name,
@@ -1919,7 +1919,7 @@ Handle<Code>
StoreStubCompiler::CompileStoreInterceptor(
}
-Handle<Code> LoadStubCompiler::CompileLoadNonexistent(Handle<Type> type,
+Handle<Code> LoadStubCompiler::CompileLoadNonexistent(Handle<HeapType>
type,
Handle<JSObject>
last,
Handle<Name> name) {
NonexistentHandlerFrontend(type, last, name);
@@ -2001,7 +2001,7 @@ void
LoadStubCompiler::GenerateLoadViaGetter(MacroAssembler* masm,
Handle<Code> LoadStubCompiler::CompileLoadGlobal(
- Handle<Type> type,
+ Handle<HeapType> type,
Handle<GlobalObject> global,
Handle<PropertyCell> cell,
Handle<Name> name,
@@ -2055,11 +2055,11 @@ Handle<Code>
BaseLoadStoreStubCompiler::CompilePolymorphicIC(
int number_of_handled_maps = 0;
__ lw(map_reg, FieldMemOperand(receiver(), HeapObject::kMapOffset));
for (int current = 0; current < receiver_count; ++current) {
- Handle<Type> type = types->at(current);
+ Handle<HeapType> type = types->at(current);
Handle<Map> map = IC::TypeToMap(*type, isolate());
if (!map->is_deprecated()) {
number_of_handled_maps++;
- if (type->Is(Type::Number())) {
+ if (type->Is(HeapType::Number())) {
ASSERT(!number_case.is_unused());
__ bind(&number_case);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
