On 2014/01/22 13:03:52, Sven Panne wrote:
src/arm/codegen-arm.cc:862: CodePatcher* patcher =
Use "SmartPointer<CodePatcher> patcher ="...
Aha, indeed! Fixed. I thought SmartPointer is a shared pointer, but haven't
looked more closely. SmartPointer is like auto_ptr, and I guess when the
codebase will move to C++11, this will become like unique_ptr (or even be
replaced by unique_ptr), right?
I noticed the pattern SmartPointer<CompilationInfo> info(new ...), and I
used
that one, for consistency.
Or if you preferred SmartPointer<CodePatcher> patcher = new ... instead, I
will
go back and correct both my code and that old code; whichever you prefer.
https://codereview.chromium.org/144933002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
