Reviewers: Benedikt Meurer, Sven Panne,
Message:
Please take a look.
(Also, I don't have commit access, so someone will need to land this for
me.)
Description:
v8config.h: set V8_CC_MSVC when building with clang-cl
When compiling in Clang's CL-compatible mode (clang-cl), both
__clang__ and _MSC_VER will be set. In those cases, we want
to set V8_CC_MSVC so that we use the right standard library features, etc.
For example, if V8_CC_MSVC is not set, V8 will try to use std::isnan().
However, clang-cl uses MSVC'c standard library, which doesn't include
that function.
BUG=crbug.com/82385
Please review this at https://codereview.chromium.org/145593003/
SVN Base: https://github.com/v8/v8.git@master
Affected files (+4, -0 lines):
include/v8config.h
Index: include/v8config.h
diff --git a/include/v8config.h b/include/v8config.h
index
8661a0d0c79de33757785bce9bea04b9adab7c7f..0409e5bcd06635b766ff6a982b5cf632791de19d
100644
--- a/include/v8config.h
+++ b/include/v8config.h
@@ -234,6 +234,10 @@
# define V8_HAS_CXX11_FINAL (__has_feature(cxx_override_control))
# define V8_HAS_CXX11_OVERRIDE (__has_feature(cxx_override_control))
+# if defined(_MSC_VER)
+# define V8_CC_MSVC 1
+# endif
+
#elif defined(__GNUC__)
# define V8_CC_GNU 1
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
