lgtm other one comment

https://codereview.chromium.org/134733007/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/134733007/diff/1/src/hydrogen.cc#newcode3922
src/hydrogen.cc:3922:
instruction->DeleteAndReplaceWith(instruction->ActualValue());
Not sure this is safe for every kind of instruction. Probably only want
to DeleteAndReplaceWith() when ActualValue() != this, i.e. below.

https://codereview.chromium.org/134733007/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to