https://codereview.chromium.org/141653009/diff/1/src/hydrogen-check-elimination.cc
File src/hydrogen-check-elimination.cc (right):
https://codereview.chromium.org/141653009/diff/1/src/hydrogen-check-elimination.cc#newcode292
src/hydrogen-check-elimination.cc:292: MapSet narrowed_maps =
i->Intersect(a, phase_->zone());
Would prefer the name "intersection" instead of narrowed_maps
https://codereview.chromium.org/141653009/diff/1/src/hydrogen-check-elimination.cc#newcode310
src/hydrogen-check-elimination.cc:310:
instr->DeleteAndReplaceWith(new_check_maps);
I think you want to replace both entry->check_ (if it exists) and instr
with the new check. If the entry->check_ exists, then insert the new
check before it.
https://codereview.chromium.org/141653009/diff/1/src/hydrogen-check-elimination.cc#newcode314
src/hydrogen-check-elimination.cc:314: instr->id(),
instr->value()->id()));
In this case, you haven't actually changed anything, so the trace output
would be incorrect.
https://codereview.chromium.org/141653009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
