Reviewers: Rodolph Perfetta (ARM),
Message:
PTAL
Description:
A64: Create a frame before calling InstanceOf builtin.
We need a frame because we push arguments in stack.
BUG=314606
TEST=mjsunit/regress/regress-78270
Please review this at https://codereview.chromium.org/132753004/
SVN Base: https://v8.googlecode.com/svn/branches/experimental/a64
Affected files (+3, -1 lines):
M src/a64/code-stubs-a64.cc
Index: src/a64/code-stubs-a64.cc
diff --git a/src/a64/code-stubs-a64.cc b/src/a64/code-stubs-a64.cc
index
007566c8b67b77a9331e36d8087dea53b124d5c7..c78501186fbb91409a4eb6a3a75bcf55dee2cc54
100644
--- a/src/a64/code-stubs-a64.cc
+++ b/src/a64/code-stubs-a64.cc
@@ -3338,13 +3338,15 @@ void InstanceofStub::Generate(MacroAssembler* masm)
{
// Slow-case. Tail call builtin.
__ Bind(&slow);
if (!ReturnTrueFalseObject()) {
+ FrameScope scope(masm, StackFrame::INTERNAL);
// Arguments have either been passed into registers or have been
previously
// popped. We need to push them before calling builtin.
__ Push(object, function);
- __ InvokeBuiltin(Builtins::INSTANCE_OF, JUMP_FUNCTION);
+ __ InvokeBuiltin(Builtins::INSTANCE_OF, CALL_FUNCTION);
} else {
ASM_UNIMPLEMENTED("InstanceofStub call builtin and return object");
}
+ __ Ret();
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
