Reviewers: Jakob,

Message:
Hi Jakob!

I was doing a bit of hacking on V8 and discovered this minor bug.

(All praise the silent ENUM to int coercion!).

Thanks.

Description:
Fix HGraphBuilder::AddSimulate to pass removable down correctly

It was passed as a position argument previously making all simulates added with
it conservatively FIXED_SIMULATE.

BUG=

Please review this at https://codereview.chromium.org/146013002/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+1, -1 lines):
  M src/hydrogen.cc


Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index ead56a494700d8c70664400fcfdbec99eb61a352..564a119e4463c73e4f4ec25e6410cf8c34914841 100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -1208,7 +1208,7 @@ void HGraphBuilder::AddSimulate(BailoutId id,
                                 RemovableSimulate removable) {
   ASSERT(current_block() != NULL);
   ASSERT(!graph()->IsInsideNoSideEffectsScope());
-  current_block()->AddNewSimulate(id, removable);
+  current_block()->AddNewSimulate(id, position_, removable);
 }




--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to