Revision: 18828
Author: [email protected]
Date: Fri Jan 24 14:31:05 2014 UTC
Log: A64: Skip samples that have sp = 0 in CPU profiler.
TEST=cctest/test-cpu-profiler/CollectCpuProfile
[email protected]
Review URL: https://codereview.chromium.org/146803002
http://code.google.com/p/v8/source/detail?r=18828
Modified:
/branches/experimental/a64/src/sampler.cc
=======================================
--- /branches/experimental/a64/src/sampler.cc Fri Jan 24 14:09:40 2014 UTC
+++ /branches/experimental/a64/src/sampler.cc Fri Jan 24 14:31:05 2014 UTC
@@ -340,6 +340,11 @@
#if defined(USE_SIMULATOR)
helper.FillRegisters(sample);
+ // It possible that the simulator is interrupted while it is updating
+ // the sp register. A64 simulator does this in two steps:
+ // first setting it to zero and then setting it to the new value.
+ // Bailout if sp doesn't contain the new value.
+ if (sample->sp == 0) return;
#else
// Extracting the sample from the context is extremely machine dependent.
ucontext_t* ucontext = reinterpret_cast<ucontext_t*>(context);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
