lgtm other than below comments.
https://codereview.chromium.org/144013003/diff/1/src/hydrogen-check-elimination.cc
File src/hydrogen-check-elimination.cc (right):
https://codereview.chromium.org/144013003/diff/1/src/hydrogen-check-elimination.cc#newcode176
src/hydrogen-check-elimination.cc:176: void Merge(HBasicBlock* succ,
HCheckTable* that,
Please keep the interface that it returns the "new" state. The idea
being that some implementations of state might be immutable (e.g. we
planned on using this for escape analysis as well).
https://codereview.chromium.org/144013003/diff/1/src/hydrogen-flow-engine.h
File src/hydrogen-flow-engine.h (right):
https://codereview.chromium.org/144013003/diff/1/src/hydrogen-flow-engine.h#newcode158
src/hydrogen-flow-engine.h:158: StateAt(succ)->Merge(succ, state, block,
zone_);
You will want to keep SetStateAt() as per previous comment.
https://codereview.chromium.org/144013003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
