Good idea. I made the store_mode parameter explicit for HStoreNamedField and
HStoreKeyed (for consistency).
I added review comments for all the places where store_mode is different
from
the default one (INITIALIZING_STORE).
https://codereview.chromium.org/143413019/diff/60001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/143413019/diff/60001/src/hydrogen.cc#newcode1202
src/hydrogen.cc:1202: new_value, STORE_TO_INITIALIZED_ENTRY);
The counter should have been already initialized.
https://codereview.chromium.org/143413019/diff/60001/src/hydrogen.cc#newcode5289
src/hydrogen.cc:5289: value, STORE_TO_INITIALIZED_ENTRY);
The heap number should have been initialized when the field was added.
https://codereview.chromium.org/143413019/diff/60001/src/hydrogen.cc#newcode7669
src/hydrogen.cc:7669: reduced_length, STORE_TO_INITIALIZED_ENTRY);
The array length should have been initialized earlier.
https://codereview.chromium.org/143413019/diff/60001/src/hydrogen.cc#newcode9792
src/hydrogen.cc:9792: PREINITIALIZING_STORE);
It seems that we are initializing data "outside" of the object.
https://codereview.chromium.org/143413019/diff/200001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/143413019/diff/200001/src/hydrogen.cc#newcode2503
src/hydrogen.cc:2503: PREINITIALIZING_STORE);
Storing hole here.
https://codereview.chromium.org/143413019/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
