Reviewers: Rodolph Perfetta (ARM), ulan, jochen,
Message:
Hello,
This one touches some global files, so adding reviewers from Google.
This patch allows to filter tests according to if we are running on the
simulator.
Alexandre
Description:
Introduce a parameter to skip slow tests when running with a simulator.
The tests skipped have been tested and pass when given enough time.
Please review this at https://codereview.chromium.org/137543009/
SVN Base: https://v8.googlecode.com/svn/branches/experimental/a64
Affected files (+35, -1 lines):
M test/cctest/cctest.status
M test/mjsunit/mjsunit.status
M tools/run-tests.py
Index: test/cctest/cctest.status
diff --git a/test/cctest/cctest.status b/test/cctest/cctest.status
index
2ffa390913aa6af6d1b6d6e347cf1dba49254fba..81f8f21752614bd5c2bb84d06caad5185c2d06e5
100644
--- a/test/cctest/cctest.status
+++ b/test/cctest/cctest.status
@@ -59,6 +59,24 @@ test-mark-compact/BootUpMemoryUse: PASS, PASS || FAIL if
$mode == debug
test-api/Bug618: PASS
+[ $arch == a64 && $simulator_run == True ]
+
+# Pass but take too long with the simulator.
+test-api/ExternalArrays: SKIP
+test-api/Threading1: SKIP
+
+[ $arch == a64 && $mode == debug && $simulator_run == True ]
+
+# Pass but take too long with the simulator in debug mode.
+test-api/ExternalDoubleArray: SKIP
+test-api/ExternalFloat32Array: SKIP
+test-api/ExternalFloat64Array: SKIP
+test-api/ExternalFloatArray: SKIP
+test-api/Fload32Array: SKIP
+test-api/Fload64Array: SKIP
+test-debug/DebugBreakLoop: SKIP
+
+
##############################################################################
[ $arch == arm ]
Index: test/mjsunit/mjsunit.status
diff --git a/test/mjsunit/mjsunit.status b/test/mjsunit/mjsunit.status
index
0e4959155a31a902dd1dd655fd85773eb740bbd0..6155690a7542ea4332cc38889603653f13f26862
100644
--- a/test/mjsunit/mjsunit.status
+++ b/test/mjsunit/mjsunit.status
@@ -127,6 +127,15 @@ debug-liveedit-stack-padding: SKIP
debug-liveedit-restart-frame: SKIP
debug-liveedit-double-call: SKIP
+[ $arch == a64 && $mode == debug && $simulator_run == True ]
+
+# Pass but take too long with the simulator in debug mode.
+array-sort: SKIP
+packed-elements: SKIP
+regexp-global: SKIP
+compiler/alloc-numbers: SKIP
+harmony/symbols: SKIP
+
##############################################################################
[ $arch == arm || $arch == android_arm ]
Index: tools/run-tests.py
diff --git a/tools/run-tests.py b/tools/run-tests.py
index
2c74fe05e206e82328697192ae06fa5225a57110..9336bda28c76f50ab26b52c69477d306decc3e3e
100755
--- a/tools/run-tests.py
+++ b/tools/run-tests.py
@@ -138,6 +138,10 @@ def BuildOptions():
result.add_option("--shell", help="DEPRECATED! use --shell-dir",
default="")
result.add_option("--shell-dir", help="Directory containing executables",
default="")
+ result.add_option("--dont-skip-slow-simulator-tests",
+ help="Don't skip more slow tests when using a
simulator.",
+ default=False, action="store_true",
+ dest="dont_skip_simulator_slow_tests")
result.add_option("--stress-only",
help="Only run tests with --always-opt --stress-opt",
default=False, action="store_true")
@@ -300,12 +304,15 @@ def Execute(arch, mode, args, options, suites,
workspace):
options.command_prefix,
options.extra_flags)
+ simulator_run = not options.dont_skip_simulator_slow_tests and \
+ arch in ['a64', 'arm', 'mips'] and ARCH_GUESS and arch != ARCH_GUESS
# Find available test suites and read test cases from them.
variables = {
"mode": mode,
"arch": arch,
"system": utils.GuessOS(),
- "isolates": options.isolates
+ "isolates": options.isolates,
+ "simulator_run": simulator_run
}
all_tests = []
num_tests = 0
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
