LGTM.
To record our offline conversation:
We could put the "TIMEOUT implies NOVARIANTS" logic into the test driver,
but in
non-mozilla tests, TIMEOUT means "this test is slow and sometimes times out
(maybe even only with --stress-opt), don't fail if it does", and we normally
shouldn't have tests that are expected to always time out, so marking such
tests
explicitly in the status file is better.
https://codereview.chromium.org/148913006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
