Reviewers: danno, Paul Lind, kisg, palfia, dusmil, Jakob,
Description:
Add an option for simulator case to test .status files.
The webkit/function-apply-aliased.js test fails on simulators (both MIPS
and ARM) as the printed output does not match to the expected. The
failing test forces a stack overflow exception and the ToString()
operation of the exception object fails because of an other stack
overflow and returns an empty string.
The problem is that on hardware a common JS and C stack is used so the
stack overflow can be caught in C functions also while on simulator
separated JS and C stacks are used.
This patch adds a "sim" condition to test .status files to skip tests
only on simulator.
LOG=N
BUG=v8:3124
Please review this at https://codereview.chromium.org/139233005/
SVN Base: https://github.com/v8/v8.git@gbl
Affected files (+10, -0 lines):
M test/webkit/webkit.status
M tools/run-tests.py
Index: test/webkit/webkit.status
diff --git a/test/webkit/webkit.status b/test/webkit/webkit.status
index
98935f79afaec4be856bc769d2c72829cb679726..9c4ec17026585edd00a10276556af5f3e952f242
100644
--- a/test/webkit/webkit.status
+++ b/test/webkit/webkit.status
@@ -42,4 +42,7 @@
'reentrant-caching': [SKIP],
'sort-large-array': [SKIP],
}], # 'mode == debug'
+['sim == True', {
+ 'function-apply-aliased': [SKIP],
+}], # 'sim == True'
]
Index: tools/run-tests.py
diff --git a/tools/run-tests.py b/tools/run-tests.py
index
f905c03d3f63789d39254ec978966e830f769653..1f134d1dfcb4755eb6ab588f6e0048baaf228345
100755
--- a/tools/run-tests.py
+++ b/tools/run-tests.py
@@ -33,6 +33,7 @@ import multiprocessing
import optparse
import os
from os.path import join
+import platform
import shlex
import subprocess
import sys
@@ -396,10 +397,16 @@ def Execute(arch, mode, args, options, suites,
workspace):
"mode": mode,
"no_i18n": options.no_i18n,
"system": utils.GuessOS(),
+ "sim": False,
}
all_tests = []
num_tests = 0
test_id = 0
+ machine = platform.machine()
+ if (machine and
+ (arch == "mipsel" or arch == "arm") and
+ not arch.startswith(machine)):
+ variables["sim"] = True
for s in suites:
s.ReadStatusFile(variables)
s.ReadTestCases(ctx)
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
