Reviewers: ulan,

Message:
PTAL ulan.

The aarch64 NDK still needs some work for this to work properly, but once they
make some changes this should work.

Description:
A64: Add Android_a64 build target

Please review this at https://codereview.chromium.org/137243006/

SVN Base: https://v8.googlecode.com/svn/branches/experimental/a64

Affected files (+17, -11 lines):
  M Makefile
  M Makefile.android
  M build/common.gypi


Index: Makefile
diff --git a/Makefile b/Makefile
index 8c4b35833408e488a509fb1385b0f69acb0d6f6c..616d17518380513c8b013bef599c24f2cc358572 100644
--- a/Makefile
+++ b/Makefile
@@ -206,7 +206,7 @@ endif
 ARCHES = ia32 x64 arm a64 mipsel
 DEFAULT_ARCHES = ia32 x64 arm
 MODES = release debug
-ANDROID_ARCHES = android_ia32 android_arm android_mipsel
+ANDROID_ARCHES = android_ia32 android_arm android_a64 android_mipsel
 NACL_ARCHES = nacl_ia32 nacl_x64

 # List of files that trigger Makefile regeneration:
Index: Makefile.android
diff --git a/Makefile.android b/Makefile.android
index aeff01c665e1da1c9c6fc51daff0bb6c8f671bf6..68ebe848d7aceaf500f46b2f61005741873947dc 100644
--- a/Makefile.android
+++ b/Makefile.android
@@ -26,7 +26,7 @@
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

 # Those definitions should be consistent with the main Makefile
-ANDROID_ARCHES = android_ia32 android_arm android_mipsel
+ANDROID_ARCHES = android_ia32 android_arm android_a64 android_mipsel
 MODES = release debug

 # Generates all combinations of ANDROID ARCHES and MODES,
@@ -50,16 +50,21 @@ ifeq ($(ARCH), android_arm)
   DEFINES += arm_neon=0 armv7=1
   TOOLCHAIN_ARCH = arm-linux-androideabi-4.6
 else
-  ifeq ($(ARCH), android_mipsel)
- DEFINES = target_arch=mipsel v8_target_arch=mipsel android_target_arch=mips
-    DEFINES += mips_arch_variant=mips32r2
-    TOOLCHAIN_ARCH = mipsel-linux-android-4.6
+  ifeq ($(ARCH), android_a64)
+ DEFINES = target_arch=a64 v8_target_arch=a64 android_target_arch=aarch64
+    TOOLCHAIN_ARCH = aarch64-linux-android-4.8
   else
-    ifeq ($(ARCH), android_ia32)
- DEFINES = target_arch=ia32 v8_target_arch=ia32 android_target_arch=x86
-      TOOLCHAIN_ARCH = x86-4.6
+    ifeq ($(ARCH), android_mipsel)
+      DEFINES  = target_arch=mipsel v8_target_arch=mipsel
+      DEFINES += android_target_arch=mips mips_arch_variant=mips32r2
+      TOOLCHAIN_ARCH = mipsel-linux-android-4.6
     else
-      $(error Target architecture "${ARCH}" is not supported)
+      ifeq ($(ARCH), android_ia32)
+ DEFINES = target_arch=ia32 v8_target_arch=ia32 android_target_arch=x86
+        TOOLCHAIN_ARCH = x86-4.6
+      else
+        $(error Target architecture "${ARCH}" is not supported)
+      endif
     endif
   endif
 endif
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 29b30c7212ee93a827c2ae9ead05450c45363aea..fb8a94a67a9a3999ca4502a339ef6ed0af7ba725 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -464,7 +464,8 @@
           }],
         ],
       }],
-      ['(OS=="linux") and (v8_target_arch=="x64")', {
+      ['(OS=="linux" or OS=="android") and \
+        (v8_target_arch=="x64" or v8_target_arch=="a64")', {
         # Check whether the host compiler and target compiler support the
         # '-m64' option and set it if so.
         'target_conditions': [


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to