Reviewers: Hannes Payer,
Message:
PTAL
Description:
Use HType::NonPrimitive() for non primitive HConstants.
This allows us to use the faster write barrier, omitting the
smi check when storing constant heap objects.
Please review this at https://codereview.chromium.org/150303002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -0 lines):
M src/hydrogen-instructions.cc
Index: src/hydrogen-instructions.cc
diff --git a/src/hydrogen-instructions.cc b/src/hydrogen-instructions.cc
index
889ebfd05fc6f47a4cb835269ab29ddbd686f02e..73404b94ba561ae47b528cfd3930fe49ffc5e3d1
100644
--- a/src/hydrogen-instructions.cc
+++ b/src/hydrogen-instructions.cc
@@ -361,6 +361,10 @@ HType HType::TypeFromValue(Handle<Object> value) {
result = HType::JSObject();
} else if (value->IsJSArray()) {
result = HType::JSArray();
+ } else if (value->IsHeapObject()) {
+ // TODO(bmeurer): This is currently a work-around until the new type
system
+ // is in place, where we have more precise types.
+ result = HType::NonPrimitive();
}
return result;
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
