Revision: 18951
Author: [email protected]
Date: Thu Jan 30 14:42:24 2014 UTC
Log: A64: Temporary fix for predictable code size in
LCodeGen::DoStackCheck.
[email protected], [email protected]
Review URL: https://codereview.chromium.org/132193011
http://code.google.com/p/v8/source/detail?r=18951
Modified:
/branches/experimental/a64/src/a64/lithium-codegen-a64.cc
=======================================
--- /branches/experimental/a64/src/a64/lithium-codegen-a64.cc Thu Jan 30
12:09:30 2014 UTC
+++ /branches/experimental/a64/src/a64/lithium-codegen-a64.cc Thu Jan 30
14:42:24 2014 UTC
@@ -4575,9 +4575,13 @@
__ CompareRoot(masm()->StackPointer(), Heap::kStackLimitRootIndex);
__ B(hs, &done);
- // TODO(jbramley): This PredictableCodeSizeScope fails sometimes.
Sometimes
- // the code tries to generate 3 instructions, and sometimes it tries to
- // generate 2. Work out why, and fix it.
+ // TODO(bafsa): Make sure that the EnsureSpaceForLazyDeopt inside
+ // CallCodeGeneric will not insert any nop while calling the stub by
+ // inserting them now. The EnsureSpaceForLazyDeopt in CallCodeGeneric
+ // will go away at some point during the rebase (r18642) so this will
become
+ // unecessary and should be removed at this point.
+ EnsureSpaceForLazyDeopt();
+
PredictableCodeSizeScope predictable(masm_,
Assembler::kCallSizeWithRelocation);
StackCheckStub stub;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
