Reviewers: baptiste.afsa1, ulan,
Description:
Remove ASM_UNIMPLEMENTED from Builtins::Generate_FunctionCall
It's actually called by several tests, for example with
var a = {}; a.call = Function.prototype.call; a.call();
In contrast to the _BREAK() variant ASM_UNIMPLEMENTED() doesn't trigger
any visible output, so it's not readily obvious that this code path
is actually taken
BUG=none
[email protected],[email protected]
LOG=n
Please review this at https://codereview.chromium.org/150543002/
SVN Base: https://v8.googlecode.com/svn/branches/experimental/a64
Affected files (+0, -1 lines):
M src/a64/builtins-a64.cc
Index: src/a64/builtins-a64.cc
diff --git a/src/a64/builtins-a64.cc b/src/a64/builtins-a64.cc
index
6bed82257de6d6dca5756c408eaa0bf27e20a500..e61d4a48db7cf6cfe6016988dd723654aad078d3
100644
--- a/src/a64/builtins-a64.cc
+++ b/src/a64/builtins-a64.cc
@@ -1116,7 +1116,6 @@ void Builtins::Generate_FunctionCall(MacroAssembler*
masm) {
// x4: call type (0: JS function, 1: function proxy, 2: non-function)
{ Label function, non_proxy;
__ Cbz(x4, &function);
- ASM_UNIMPLEMENTED("Builtins::Generate_FunctionCall non-function");
// Expected number of arguments is 0 for CALL_NON_FUNCTION.
__ Mov(x2, 0);
__ SetCallKind(x5, CALL_AS_METHOD);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
