Revision: 18959
Author: [email protected]
Date: Thu Jan 30 18:04:33 2014 UTC
Log: Skip webkit/function-apply-aliased.js when running on simulators.
The webkit/function-apply-aliased.js test fails on simulators (both MIPS
and ARM) as the printed output does not match to the expected. The
failing test forces a stack overflow exception and the ToString()
operation of the exception object fails because of an other stack
overflow and returns an empty string.
The problem is that on hardware a common JS and C stack is used so the
stack overflow can be caught in C functions also while on simulator
separated JS and C stacks are used.
This patch adds a "sim" condition to test .status files to skip tests
only on simulator.
LOG=N
BUG=v8:3124
[email protected], [email protected]
Review URL: https://codereview.chromium.org/139233005
Patch from Balazs Kilvady <[email protected]>.
http://code.google.com/p/v8/source/detail?r=18959
Modified:
/branches/bleeding_edge/test/webkit/webkit.status
/branches/bleeding_edge/tools/run-tests.py
=======================================
--- /branches/bleeding_edge/test/webkit/webkit.status Wed Nov 13 11:09:47
2013 UTC
+++ /branches/bleeding_edge/test/webkit/webkit.status Thu Jan 30 18:04:33
2014 UTC
@@ -42,4 +42,7 @@
'reentrant-caching': [SKIP],
'sort-large-array': [SKIP],
}], # 'mode == debug'
+['simulator', {
+ 'function-apply-aliased': [SKIP],
+}], # 'simulator'
]
=======================================
--- /branches/bleeding_edge/tools/run-tests.py Wed Jan 29 15:30:41 2014 UTC
+++ /branches/bleeding_edge/tools/run-tests.py Thu Jan 30 18:04:33 2014 UTC
@@ -33,6 +33,7 @@
import optparse
import os
from os.path import join
+import platform
import shlex
import subprocess
import sys
@@ -387,6 +388,13 @@
options.no_i18n)
# Find available test suites and read test cases from them.
+ machine = platform.machine()
+ if (machine and
+ (arch == "mipsel" or arch == "arm") and
+ not arch.startswith(machine)):
+ use_simulator = True
+ else:
+ use_simulator = False
variables = {
"arch": arch,
"asan": options.asan,
@@ -396,6 +404,7 @@
"mode": mode,
"no_i18n": options.no_i18n,
"system": utils.GuessOS(),
+ "simulator": use_simulator,
}
all_tests = []
num_tests = 0
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
