Revision: 18963
Author: [email protected]
Date: Thu Jan 30 19:01:33 2014 UTC
Log: Remove ASM_UNIMPLEMENTED from Builtins::Generate_FunctionCall
It's actually called by several tests, for example with
var a = {}; a.call = Function.prototype.call; a.call();
In contrast to the _BREAK() variant ASM_UNIMPLEMENTED() doesn't trigger
any visible output, so it's not readily obvious that this code path
is actually taken
BUG=none
[email protected], [email protected]
LOG=n
Review URL: https://codereview.chromium.org/150543002
http://code.google.com/p/v8/source/detail?r=18963
Modified:
/branches/experimental/a64/src/a64/builtins-a64.cc
=======================================
--- /branches/experimental/a64/src/a64/builtins-a64.cc Thu Jan 30 12:09:30
2014 UTC
+++ /branches/experimental/a64/src/a64/builtins-a64.cc Thu Jan 30 19:01:33
2014 UTC
@@ -1115,7 +1115,6 @@
// x4: call type (0: JS function, 1: function proxy, 2: non-function)
{ Label function, non_proxy;
__ Cbz(x4, &function);
- ASM_UNIMPLEMENTED("Builtins::Generate_FunctionCall non-function");
// Expected number of arguments is 0 for CALL_NON_FUNCTION.
__ Mov(x2, 0);
__ SetCallKind(x5, CALL_AS_METHOD);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
