[v8-dev] Fix compiler error on MacOS, remove unused ParameterCount member in CallInterceptorCompiler. (issue 132113004)

Thu, 30 Jan 2014 22:59:26 -0800 

Reviewers: Benedikt Meurer,

Description:
Fix compiler error on MacOS, remove unused ParameterCount member in
CallInterceptorCompiler.

BUG=

Please review this at https://codereview.chromium.org/132113004/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+4, -16 lines):
  M src/arm/stub-cache-arm.cc
  M src/ia32/stub-cache-ia32.cc
  M src/mips/stub-cache-mips.cc
  M src/x64/stub-cache-x64.cc


Index: src/arm/stub-cache-arm.cc
diff --git a/src/arm/stub-cache-arm.cc b/src/arm/stub-cache-arm.cc
index 8ef852b99c3e342abe916f73533bc5ade666c7d0..793d30c62ef597f97bb9de434945e40906f654a7 100644 
--- a/src/arm/stub-cache-arm.cc
+++ b/src/arm/stub-cache-arm.cc
@@ -861,10 +861,8 @@ static void GenerateFastApiCall(MacroAssembler* masm,
 class CallInterceptorCompiler BASE_EMBEDDED {
  public:
   CallInterceptorCompiler(CallStubCompiler* stub_compiler,
-                          const ParameterCount& arguments,
                           Register name)
       : stub_compiler_(stub_compiler),
-        arguments_(arguments),
         name_(name) {}

   void Compile(MacroAssembler* masm,
@@ -997,7 +995,6 @@ class CallInterceptorCompiler BASE_EMBEDDED {
   }

   CallStubCompiler* stub_compiler_;
-  const ParameterCount& arguments_;
   Register name_;
 };
@@ -1570,7 +1567,7 @@ Handle<Code> CallStubCompiler::CompileCallInterceptor(Handle<JSObject> object, 
   // Get the receiver from the stack.
   __ ldr(r1, MemOperand(sp, argc * kPointerSize));

-  CallInterceptorCompiler compiler(this, arguments(), r2);
+  CallInterceptorCompiler compiler(this, r2);
   compiler.Compile(masm(), object, holder, name, &lookup, r1, r3, r4, r0,
                    &miss);

Index: src/ia32/stub-cache-ia32.cc
diff --git a/src/ia32/stub-cache-ia32.cc b/src/ia32/stub-cache-ia32.cc
index c8a9ce4b3175607a4859172e36fd991f96cefe59..42ceb2489c1c4eb76080c2afc5c3f75ee2e66922 100644 
--- a/src/ia32/stub-cache-ia32.cc
+++ b/src/ia32/stub-cache-ia32.cc
@@ -500,10 +500,8 @@ static void GenerateFastApiCall(MacroAssembler* masm,
 class CallInterceptorCompiler BASE_EMBEDDED {
  public:
   CallInterceptorCompiler(CallStubCompiler* stub_compiler,
-                          const ParameterCount& arguments,
                           Register name)
       : stub_compiler_(stub_compiler),
-        arguments_(arguments),
         name_(name) {}

   void Compile(MacroAssembler* masm,
@@ -637,7 +635,6 @@ class CallInterceptorCompiler BASE_EMBEDDED {
   }

   CallStubCompiler* stub_compiler_;
-  const ParameterCount& arguments_;
   Register name_;
 };
@@ -1579,7 +1576,7 @@ Handle<Code> CallStubCompiler::CompileCallInterceptor(Handle<JSObject> object, 
   // Get the receiver from the stack.
   __ mov(edx, Operand(esp, (argc + 1) * kPointerSize));

-  CallInterceptorCompiler compiler(this, arguments(), ecx);
+  CallInterceptorCompiler compiler(this, ecx);
compiler.Compile(masm(), object, holder, name, &lookup, edx, ebx, edi, eax, 
                    &miss);

Index: src/mips/stub-cache-mips.cc
diff --git a/src/mips/stub-cache-mips.cc b/src/mips/stub-cache-mips.cc
index 9bb3e768f94448989544443104156c0e46f18746..a44816356e7c07d69bc81231afae0ceec2d1a887 100644 
--- a/src/mips/stub-cache-mips.cc
+++ b/src/mips/stub-cache-mips.cc
@@ -849,10 +849,8 @@ static void GenerateFastApiCall(MacroAssembler* masm,
 class CallInterceptorCompiler BASE_EMBEDDED {
  public:
   CallInterceptorCompiler(CallStubCompiler* stub_compiler,
-                          const ParameterCount& arguments,
                           Register name)
       : stub_compiler_(stub_compiler),
-        arguments_(arguments),
         name_(name) {}

   void Compile(MacroAssembler* masm,
@@ -984,7 +982,6 @@ class CallInterceptorCompiler BASE_EMBEDDED {
   }

   CallStubCompiler* stub_compiler_;
-  const ParameterCount& arguments_;
   Register name_;
 };
@@ -1553,7 +1550,7 @@ Handle<Code> CallStubCompiler::CompileCallInterceptor(Handle<JSObject> object, 
   // Get the receiver from the stack.
   __ lw(a1, MemOperand(sp, argc * kPointerSize));

-  CallInterceptorCompiler compiler(this, arguments(), a2);
+  CallInterceptorCompiler compiler(this, a2);
   compiler.Compile(masm(), object, holder, name, &lookup, a1, a3, t0, a0,
                    &miss);

Index: src/x64/stub-cache-x64.cc
diff --git a/src/x64/stub-cache-x64.cc b/src/x64/stub-cache-x64.cc
index 8be604fb0bc07ab91ae8b30d969454ae3c3094d2..0244eb0c0d820b0eb75825ac40670cf752b0e06a 100644 
--- a/src/x64/stub-cache-x64.cc
+++ b/src/x64/stub-cache-x64.cc
@@ -471,10 +471,8 @@ static void GenerateFastApiCall(MacroAssembler* masm,
 class CallInterceptorCompiler BASE_EMBEDDED {
  public:
   CallInterceptorCompiler(CallStubCompiler* stub_compiler,
-                          const ParameterCount& arguments,
                           Register name)
       : stub_compiler_(stub_compiler),
-        arguments_(arguments),
         name_(name) {}

   void Compile(MacroAssembler* masm,
@@ -609,7 +607,6 @@ class CallInterceptorCompiler BASE_EMBEDDED {
   }

   CallStubCompiler* stub_compiler_;
-  const ParameterCount& arguments_;
   Register name_;
 };
@@ -1465,7 +1462,7 @@ Handle<Code> CallStubCompiler::CompileCallInterceptor(Handle<JSObject> object, 
   StackArgumentsAccessor args(rsp, arguments());
   __ movp(rdx, args.GetReceiverOperand());

-  CallInterceptorCompiler compiler(this, arguments(), rcx);
+  CallInterceptorCompiler compiler(this, rcx);
compiler.Compile(masm(), object, holder, name, &lookup, rdx, rbx, rdi, rax, 
                    &miss);



--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to