Reviewers: Jakob,
Message:
PTAL
Description:
Fix deopt fuzzer variable set up.
Adds the simulator variable configuration from r18959 to the deopt fuzzer.
BUG=
Please review this at https://codereview.chromium.org/143403004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+9, -8 lines):
M tools/run-deopt-fuzzer.py
M tools/run-tests.py
M tools/testrunner/local/utils.py
Index: tools/run-deopt-fuzzer.py
diff --git a/tools/run-deopt-fuzzer.py b/tools/run-deopt-fuzzer.py
index
c41dacbbe0831dd1fd02a7add8a5364b695e1c7f..489f447bf2d00cefcb648ba8c03d2a84d1072a07
100755
--- a/tools/run-deopt-fuzzer.py
+++ b/tools/run-deopt-fuzzer.py
@@ -373,6 +373,7 @@ def Execute(arch, mode, args, options, suites,
workspace):
"isolates": options.isolates,
"mode": mode,
"no_i18n": False,
+ "simulator": utils.UseSimulator(arch),
"system": utils.GuessOS(),
}
all_tests = []
Index: tools/run-tests.py
diff --git a/tools/run-tests.py b/tools/run-tests.py
index
ec7021e55e8c5a956ff420da5b0fc482000abcb2..52f5c7f32aa763647eabfce371764265ea06ae93
100755
--- a/tools/run-tests.py
+++ b/tools/run-tests.py
@@ -388,13 +388,6 @@ def Execute(arch, mode, args, options, suites,
workspace):
options.no_i18n)
# Find available test suites and read test cases from them.
- machine = platform.machine()
- if (machine and
- (arch == "mipsel" or arch == "arm") and
- not arch.startswith(machine)):
- use_simulator = True
- else:
- use_simulator = False
variables = {
"arch": arch,
"asan": options.asan,
@@ -403,8 +396,8 @@ def Execute(arch, mode, args, options, suites,
workspace):
"isolates": options.isolates,
"mode": mode,
"no_i18n": options.no_i18n,
+ "simulator": utils.UseSimulator(arch),
"system": utils.GuessOS(),
- "simulator": use_simulator,
}
all_tests = []
num_tests = 0
Index: tools/testrunner/local/utils.py
diff --git a/tools/testrunner/local/utils.py
b/tools/testrunner/local/utils.py
index
61ee7dac67bed1f6699b5757ceeb0eab4d8ee12a..508709f87d2d108a4f8901b337a1ebf25197e042
100644
--- a/tools/testrunner/local/utils.py
+++ b/tools/testrunner/local/utils.py
@@ -78,6 +78,13 @@ def GuessOS():
return None
+def UseSimulator(arch):
+ machine = platform.machine()
+ return (machine and
+ (arch == "mipsel" or arch == "arm") and
+ not arch.startswith(machine))
+
+
# This will default to building the 32 bit VM even on machines that are
# capable of running the 64 bit VM.
def DefaultArch():
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
