Reviewers: ulan,
Description:
Add a test for ArgumentsAccessStub::GenerateNewNonStrictSlow
BUG=none
[email protected]
LOG=y
Please review this at https://codereview.chromium.org/150543005/
SVN Base: https://v8.googlecode.com/svn/branches/experimental/a64
Affected files (+7, -12 lines):
M src/a64/code-stubs-a64.cc
A + test/mjsunit/function-arguments-duplicate.js
Index: src/a64/code-stubs-a64.cc
diff --git a/src/a64/code-stubs-a64.cc b/src/a64/code-stubs-a64.cc
index
959958e4c520344acd4ed7ed081be12e2bb3078f..2268492bbb300e1ff7553ceab986a994396499e9
100644
--- a/src/a64/code-stubs-a64.cc
+++ b/src/a64/code-stubs-a64.cc
@@ -3229,8 +3229,6 @@ void
ArgumentsAccessStub::GenerateNewNonStrictSlow(MacroAssembler* masm) {
// jssp[8]: address of receiver argument
// jssp[16]: function
- ASM_UNIMPLEMENTED("GenerateNewNonStrictSlow: This has not been tested.");
-
// Check if the calling frame is an arguments adaptor frame.
Label runtime;
Register caller_fp = x10;
Index: test/mjsunit/function-arguments-duplicate.js
diff --git a/test/mjsunit/compiler/safepoint.js
b/test/mjsunit/function-arguments-duplicate.js
similarity index 86%
copy from test/mjsunit/compiler/safepoint.js
copy to test/mjsunit/function-arguments-duplicate.js
index
ee8fcf0dee2a0e0519dc42a4b1e3320120ed551d..80f03a106b30a7e2f984a83b9d54b2edd8fb840a
100644
--- a/test/mjsunit/compiler/safepoint.js
+++ b/test/mjsunit/function-arguments-duplicate.js
@@ -1,4 +1,4 @@
-// Copyright 2010 the V8 project authors. All rights reserved.
+// Copyright 2014 the V8 project authors. All rights reserved.
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
@@ -25,15 +25,12 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-// Flags: --expose-gc
+// Execises ArgumentsAccessStub::GenerateNewNonStrictSlow.
-function Test(o) {
- var x = o;
- var y = this;
- x.gc();
- x.gc();
- return y;
+function f(a, a) {
+ assertEquals(2, a);
+ assertEquals(1, arguments[0]);
+ assertEquals(2, arguments[1]);
}
-var o = {gc:gc};
-assertTrue(Test(o) === this);
+f(1, 2);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
