Reviewers: m.m.capewell,
Message:
PTAL
Description:
A64: Fix assertion in DoMathMinMax.
The instruction can handle SMIs.
TEST=mjsunit/math-min-max
Please review this at https://codereview.chromium.org/151323002/
SVN Base: https://v8.googlecode.com/svn/branches/experimental/a64
Affected files (+2, -2 lines):
M src/a64/lithium-a64.cc
Index: src/a64/lithium-a64.cc
diff --git a/src/a64/lithium-a64.cc b/src/a64/lithium-a64.cc
index
a2fd9fc329ddd20567eb10b84e3586bccb1a6f2d..8fd59c779d0ae3c7123ce634da8b27f461245ca9
100644
--- a/src/a64/lithium-a64.cc
+++ b/src/a64/lithium-a64.cc
@@ -1824,8 +1824,8 @@ LInstruction*
LChunkBuilder::DoMathMinMax(HMathMinMax* instr) {
LOperand* left = NULL;
LOperand* right = NULL;
if (instr->representation().IsSmiOrInteger32()) {
- ASSERT(instr->left()->representation().IsInteger32());
- ASSERT(instr->right()->representation().IsInteger32());
+
ASSERT(instr->left()->representation().Equals(instr->representation()));
+
ASSERT(instr->right()->representation().Equals(instr->representation()));
left = UseRegisterAtStart(instr->BetterLeftOperand());
right = UseRegisterOrConstantAtStart(instr->BetterRightOperand());
} else {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
