On 2014/01/27 06:34:29, Benedikt Meurer wrote:
I'd prefer to cherry-pick the current Chromium state for all platforms.
Ok, I integrated all the recent development on atomic ops from Chromium.
Here is
a summary of differences between what's in Chromium vs. what would be in V8
after applying my patch.
* Copyright headers, some horizontal and vertical whitespace corrections,
and
other similarly-trivial changes.
* Namespace: base::subtle vs. v8::internal.
* Chromium-specific macros (e.g. ARCH_CPU_NNNN) vs. V8-specific macros (e.g.
V8_HOST_ARCH_NNNN).
* The NaCl changes are missing. I wasn't able to test NaCl, and I wasn't
sure
those changes are needed.
* There were some other existing (minor, non-semantic) changes between V8
and
Chromium that seemed deliberate in V8, and I haven't touched those, in
atomicops_internals_x86_gcc.{h,cc} and atomicops_internals_tsan.h.
* I integrated the Chromium unit test (atomicops_unittest.cc) into cctest,
following the cctest conventions and restrictions, as well as working
around the
more limited overload-resolution choices given by the CHECK_EQ macro.
Tested on Linux (ARM, x64, ia32), Mac (x64, ia32), Windows (ia32).
https://codereview.chromium.org/129813008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
