https://codereview.chromium.org/152613002/diff/20006/src/heap-inl.h
File src/heap-inl.h (right):
https://codereview.chromium.org/152613002/diff/20006/src/heap-inl.h#newcode491
src/heap-inl.h:491: ASSERT(heap->InFromSpace(object));
On 2014/02/03 11:26:32, Benedikt Meurer wrote:
Is this ASSERT actually correct?
Yes, because we should just look at objects which are in from space.
https://codereview.chromium.org/152613002/diff/20006/src/heap-inl.h#newcode506
src/heap-inl.h:506:
On 2014/02/03 11:49:28, Benedikt Meurer wrote:
On 2014/02/03 10:30:18, Hannes Payer wrote:
> Not that I removed (ptr == top) since we have filler now all the
time. I can
> bring back this check, but it shouldn't matter anymore. WDYT?
Please add a code comment why it's safe to skip the top/high check
here.
Done.
https://codereview.chromium.org/152613002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
