https://codereview.chromium.org/152863002/diff/30001/src/accessors.h
File src/accessors.h (right):
https://codereview.chromium.org/152863002/diff/30001/src/accessors.h#newcode103
src/accessors.h:103: template <class T>
You don't necessarily need to move this to the header file. I'd keep the
implementation in the .cc and specialise the template to the only two
types we need.
https://codereview.chromium.org/152863002/diff/30001/src/hydrogen.h
File src/hydrogen.h (right):
https://codereview.chromium.org/152863002/diff/30001/src/hydrogen.h#newcode2313
src/hydrogen.h:2313: return
Accessors::IsJSObjectFieldAccessor<Type>(type_, name_, &offset);
Was it necessary to specify the template argument?
https://codereview.chromium.org/152863002/diff/30001/src/ic.h
File src/ic.h (right):
https://codereview.chromium.org/152863002/diff/30001/src/ic.h#newcode142
src/ic.h:142: template<class T>
Same here.
https://codereview.chromium.org/152863002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
