After rebasing and very final review of changes I found that the check in
load
elimination was not fully correct. I also added an ASSERT that there must
be no
loads from non observable in-object fields (see patch set 6).
PTAL.
https://codereview.chromium.org/149063010/diff/160001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/149063010/diff/160001/src/hydrogen.cc#newcode1201
src/hydrogen.cc:1201: Add<HStoreNamedField>(reference,
HObjectAccess::ForCounter(),
On 2014/02/03 18:08:28, Toon Verwaest wrote:
join lines
Done.
https://codereview.chromium.org/149063010/diff/160001/src/hydrogen.cc#newcode1339
src/hydrogen.cc:1339: Add<HStoreNamedField>(object,
HObjectAccess::ForArrayLength(kind),
On 2014/02/03 18:08:28, Toon Verwaest wrote:
join lines
It will be too long line.
https://codereview.chromium.org/149063010/diff/160001/src/hydrogen.cc#newcode2340
src/hydrogen.cc:2340: Add<HStoreNamedField>(elements,
HObjectAccess::ForFixedArrayLength(),
On 2014/02/03 18:08:28, Toon Verwaest wrote:
join lines
Too long line.
https://codereview.chromium.org/149063010/diff/160001/src/hydrogen.cc#newcode2477
src/hydrogen.cc:2477: Add<HStoreNamedField>(object,
HObjectAccess::ForElementsPointer(),
On 2014/02/03 18:08:28, Toon Verwaest wrote:
join lines
Too long line.
https://codereview.chromium.org/149063010/diff/340001/src/hydrogen-load-elimination.cc
File src/hydrogen-load-elimination.cc (right):
https://codereview.chromium.org/149063010/diff/340001/src/hydrogen-load-elimination.cc#newcode196
src/hydrogen-load-elimination.cc:196: // There must be no loads from non
observable in-object properties.
New code.
https://codereview.chromium.org/149063010/diff/340001/src/hydrogen-load-elimination.cc#newcode224
src/hydrogen-load-elimination.cc:224: if (instr->access().IsInobject()
&&
New code.
https://codereview.chromium.org/149063010/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
