Revision: 19047
Author: [email protected]
Date: Tue Feb 4 08:30:35 2014 UTC
Log: Dispose Isolate at end of cctest.
No measurable change in test running time, we clean up only trivial
known things at disposal time and do not walk the heap, run real
finalizers, etc.
[email protected]
Review URL: https://codereview.chromium.org/135153007
http://code.google.com/p/v8/source/detail?r=19047
Modified:
/branches/bleeding_edge/test/cctest/cctest.h
=======================================
--- /branches/bleeding_edge/test/cctest/cctest.h Fri Jan 31 07:29:25 2014
UTC
+++ /branches/bleeding_edge/test/cctest/cctest.h Tue Feb 4 08:30:35 2014
UTC
@@ -131,8 +131,7 @@
v8::Isolate* isolate = CcTest::isolate());
static void TearDown() {
- // TODO(svenpanne) Enable this when our cctests are fixed.
- // if (isolate_ != NULL) isolate_->Dispose();
+ if (isolate_ != NULL) isolate_->Dispose();
}
private:
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
