Reviewers: m.m.capewell,
Description:
A64: Pregenerate the CEntryStub when saving FP registers.
Please review this at https://codereview.chromium.org/153723002/
SVN Base: https://v8.googlecode.com/svn/branches/experimental/a64
Affected files (+3, -4 lines):
M src/a64/code-stubs-a64.cc
Index: src/a64/code-stubs-a64.cc
diff --git a/src/a64/code-stubs-a64.cc b/src/a64/code-stubs-a64.cc
index
3d6c690713755cd511c1857169a5e8d82b5128f0..0608d3d899ec801c40a95bf861ba1cad160a2636
100644
--- a/src/a64/code-stubs-a64.cc
+++ b/src/a64/code-stubs-a64.cc
@@ -2166,16 +2166,15 @@ bool CEntryStub::NeedsImmovableCode() {
bool CEntryStub::IsPregenerated() {
- // TODO(jbramley): We should pregenerate kSaveFPRegs too, once we
support it.
- return (save_doubles_ == kDontSaveFPRegs) && (result_size_ == 1);
+ return result_size_ == 1;
}
void CEntryStub::GenerateAheadOfTime(Isolate* isolate) {
CEntryStub stub(1, kDontSaveFPRegs);
stub.GetCode(isolate)->set_is_pregenerated(true);
- // TODO(jbramley): We should generate kSaveFPRegs here too, but it is
not yet
- // implemented by CEntryStub because it is only used by Lithium.
+ CEntryStub stub_fp(1, kSaveFPRegs);
+ stub_fp.GetCode(isolate)->set_is_pregenerated(true);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
