https://codereview.chromium.org/152813003/diff/20001/test/cctest/test-mementos.cc
File test/cctest/test-mementos.cc (right):
https://codereview.chromium.org/152813003/diff/20001/test/cctest/test-mementos.cc#newcode45
test/cctest/test-mementos.cc:45: CompileRun("var a = [];");
On 2014/02/04 09:01:11, mvstanton wrote:
On 2014/02/04 08:27:44, Benedikt Meurer wrote:
> This is rather fragile. Why not simply call the Heap method to
allocate a
> JSArray and manually stick an AllocationMemento after the new top
pointer?
But since mementos are a part of the code now (there is no longer a
flag to
control this), I'd say go ahead and trust that a memento will be
emitted. You
could assert that the word after the JSArray is the memento map.
We can do that as well.
https://codereview.chromium.org/152813003/diff/20001/test/cctest/test-mementos.cc#newcode60
test/cctest/test-mementos.cc:60:
heap->CollectAllGarbage(Heap::kAbortIncrementalMarkingMask);
On 2014/02/04 09:01:11, mvstanton wrote:
Have you verified that crash would happen here?
Yes, it would crash without the fix.
https://codereview.chromium.org/152813003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
