Reviewers: dcarney,
Message:
Please take a look.
Description:
Correctly recognize external strings.
Since r15906, cons strings in old pointer space that are made external
remain cons strings, and point to a newly-allocated external string. This
is because external strings are not allow in the pointer space.
However, v8::String::IsExternal and related methods do not reflect this.
The consequence is that the embedder cannot take advantage of external
strings.
Note that v8::String::CanMakeExternal still returns false for cons strings
due to AccessCheck not being GC safe (see r17023).
BUG=268686
LOG=N
Please review this at https://codereview.chromium.org/153803003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+133, -47 lines):
M include/v8.h
M src/api.cc
M src/objects-inl.h
M test/cctest/test-api.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
