lgtm
https://codereview.chromium.org/153803003/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/153803003/diff/1/include/v8.h#newcode6011
include/v8.h:6011: String::ExternalStringResourceBase*
String::GetExternalStringResourceBase(
this function is ridiculously hot in some dromaeo benchmark, so you
can't land it like this.
maybe try doing some reordering
if (string_type == I::kExternalRepresentationTag) {
return ...
} else if (string_type != I::kConsRepresentationTag) {
return NULL;
}
return slow_case()
https://codereview.chromium.org/153803003/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/153803003/diff/1/src/api.cc#newcode4714
src/api.cc:4714: if (i::StringShape(str).IsCons()) {
extract these 4 lines into a static function
https://codereview.chromium.org/153803003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
