On Tue, Feb 4, 2014 at 3:57 PM, <[email protected]> wrote: > +sven > > Sven, any idea how to test this code path? > > https://codereview.chromium.org/138943008/diff/1/src/a64/ > lithium-gap-resolver-a64.cc > File src/a64/lithium-gap-resolver-a64.cc (right): > > https://codereview.chromium.org/138943008/diff/1/src/a64/ > lithium-gap-resolver-a64.cc#newcode298 > src/a64/lithium-gap-resolver-a64.cc:298: __ Ldr(kSavedValue, src); [...] >
To be honest: Don't even try to write any tests for the register allocator/gap resolver, we simply don't have the necessary machinery. The last similar test worked exactly 3 hours, after that it was not testing the code path in question anymore. Commit and hope for the best. The real "test" will be surfing complex web sites with an A64-enabled Debug-Chrome. Sad, but true... -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
