Reviewers: dcarney,
Message:
Committed patchset #1 manually as r19086 (tree was closed).
Description:
Explicitly disallow stores to JSObjectAccessors (for now).
[email protected]
Committed: https://code.google.com/p/v8/source/detail?r=19086
Please review this at https://codereview.chromium.org/154873002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -6 lines):
M src/hydrogen.cc
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index
818559634690f9060ec95b3bb434aed0a92fa790..1593301e2ec715f7e67f0bfb17446f9941ad9fb0
100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -5442,12 +5442,7 @@ bool
HOptimizedGraphBuilder::PropertyAccessInfo::LookupInPrototypes() {
bool HOptimizedGraphBuilder::PropertyAccessInfo::CanAccessMonomorphic() {
if (!CanInlinePropertyAccess(type_)) return false;
- if (IsJSObjectFieldAccessor()) {
- // We should never have gathered typefeedback for JSObjectFieldAccessor
- // stores.
- ASSERT(IsLoad());
- return true;
- }
+ if (IsJSObjectFieldAccessor()) return IsLoad();
if (!LookupDescriptor()) return false;
if (lookup_.IsFound()) {
if (IsLoad()) return true;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
